Avoid throwing an exception for failed coercions with dry-types 1.x#93
Open
shepmaster wants to merge 1 commit intoapotonick:masterfrom
Open
Avoid throwing an exception for failed coercions with dry-types 1.x#93shepmaster wants to merge 1 commit intoapotonick:masterfrom
shepmaster wants to merge 1 commit intoapotonick:masterfrom
Conversation
dry-types 0.15 and 1.x changed how failed coercions are
reported. Older versions returned the original value while newer
versions raise an exception.
0.14.1:
```ruby
Types::Params::Integer['cow']
# => "cow"
```
1.7.1:
```ruby
Types::Params::Integer['cow']
# *** Dry::Types::CoercionError Exception: invalid value for Integer(): "cow"
```
Fortunately, the constructor accepts an optional block:
> When a block is passed, `{#call}` will never throw an exception on
> failed coercion, instead it will call the block.
Doubly-fortunately, the block appears to be ignored on older versions
of dry-types.
To preserve the current behavior, we update to use a block that
returns the original value.
Owner
|
In CI I see two failures: By always adding that "soft block" we apparently changed expected behavior, need to check out what's the best way to do this. thanks for this PR! 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dry-types 0.15 and 1.x changed how failed coercions are reported. Older versions returned the original value while newer versions raise an exception.
0.14.1:
1.7.1:
Fortunately, the constructor accepts an optional block:
Doubly-fortunately, the block appears to be ignored on older versions of dry-types.
To preserve the current behavior, we update to use a block that returns the original value.